Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve phpunit configuration 2.x #109

Conversation

alexislefebvre
Copy link
Collaborator

Cherry-picks from #8

@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch 3 times, most recently from 6d2bedf to ec80721 Compare April 19, 2021 21:57
@alexislefebvre alexislefebvre added this to the 2.x milestone Apr 19, 2021
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch 2 times, most recently from 2470011 to d3a5b75 Compare May 30, 2021 12:38
@alexislefebvre
Copy link
Collaborator Author

alexislefebvre commented May 30, 2021

It looks like tests are failing randomly because sometimes the cache has been populated before running the tests that depend on them.

It could be sure by deleting the cache of fixtures before running the tests (dirty) or avoiding collision in caches (clean).

@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from d3a5b75 to 1b5fc3e Compare May 30, 2021 12:51
@alexislefebvre
Copy link
Collaborator Author

alexislefebvre commented Jul 20, 2021

The tests that rely on users ids are fragile, they should be updated. For example: fetch user by email instead of id.

@alexislefebvre alexislefebvre self-assigned this Jul 20, 2021
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch 2 times, most recently from 35bbd24 to 6eb4b71 Compare July 20, 2021 22:16
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from 6eb4b71 to be20892 Compare September 15, 2021 20:17
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from be20892 to 5cfd96e Compare February 25, 2022 16:19
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch 3 times, most recently from f6f0367 to 2752bef Compare July 7, 2022 20:57
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from 0edc770 to 5bf63d1 Compare October 4, 2022 23:24
@alexislefebvre
Copy link
Collaborator Author

TODO: check that the issue is not how private static $cachedMetadatas = []; is populated or not emptied when it should, see calls to

@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from 5bf63d1 to 8bba0d6 Compare April 4, 2023 19:54
@alexislefebvre alexislefebvre force-pushed the improve-phpunit-configuration-2.x branch from 8bba0d6 to 402ed42 Compare November 5, 2023 15:39
@alexislefebvre alexislefebvre deleted the improve-phpunit-configuration-2.x branch March 11, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant