Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: migrate deployment parameter page to Angular and update to version 17.1 #739

Merged
merged 19 commits into from
Feb 21, 2024

Conversation

llorentelemmc
Copy link
Contributor

@llorentelemmc llorentelemmc commented Feb 6, 2024

@yvespp while adding user permissions to deployment-parameter and tags components in Angular, I noticed that permissions are defined as either old or new (AMW_business/src/main/java/ch/puzzle/itc/mobiliar/business/security/entity/Permission.java). Do you know the reason why some are defined as old and some as new, and is it okay that MANAGE_GLOBAL_TAGS and MANAGE_DEPLOYMENT_PARAMETER are old?

@llorentelemmc llorentelemmc requested a review from mburri February 6, 2024 13:06
@llorentelemmc llorentelemmc self-assigned this Feb 6, 2024
@StephGit
Copy link
Contributor

StephGit commented Feb 6, 2024

Please rebase to resolve the conflicts and fix the test deployment-parameter.component.spec.ts

@yvespp yvespp added this to the Version 1.17.35 milestone Feb 8, 2024
@llorentelemmc llorentelemmc requested a review from yvespp February 13, 2024 10:54
@yvespp
Copy link
Member

yvespp commented Feb 15, 2024

@yvespp while adding user permissions to deployment-parameter and tags components in Angular, I noticed that permissions are defined as either old or new (AMW_business/src/main/java/ch/puzzle/itc/mobiliar/business/security/entity/Permission.java). Do you know the reason why some are defined as old and some as new, and is it okay that MANAGE_GLOBAL_TAGS and MANAGE_DEPLOYMENT_PARAMETER are old?

Yes that's ok. The name is a bit misleading, the old permissions are global and the new are per resource, env etc. It's more like permissions are from the old (global) or new (scoped) permission concept.

@yvespp
Copy link
Member

yvespp commented Feb 15, 2024

When switch from JSF (e.g. Propert Types) directly to Tags and Deployment Parameter I can see the "Add key"/"Add tag" button, but if I switch from an Angular page to the two new pages it doesn't show the buttons...
image
Same for the delete buttons.

@yvespp
Copy link
Member

yvespp commented Feb 15, 2024

When I try to add a duplicate tag, the error toast sometimes shows for a short time only (less than a second, sometime it just blinks). The only reliable way I found to reproduce this spamming the add button with the same tag.

Copy link
Member

@yvespp yvespp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me now, thanks!
The toast still has a strange behaviour. It looks like the timer on the component keeps running even if a new toast is show (replacing the old before it's time) and then the old timer closes the new toast. Timer:


May the old timer has to be canceled or it should only hide the toast if it matches the toast.
Should we merge this and you have a look in a separate issue?

@StephGit
Copy link
Contributor

We resolved the timeout issue with clearing the old one first.

A improvement for the future would be, to show multiple toast instead of only one. Should we create a story for a toastContainer-Component?

@yvespp
Copy link
Member

yvespp commented Feb 21, 2024

A improvement for the future would be, to show multiple toast instead of only one. Should we create a story for a toastContainer-Component?

I created an new issue for it: #744
NG-Bootstrap already hase something like this, maybe that could be used?

@yvespp yvespp merged commit edd66bf into master Feb 21, 2024
1 check passed
@yvespp yvespp deleted the feature/737-angular-deployment-parameter branch February 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace JSF GUI in Settings -> Deployment Parameter page with Angular
3 participants