-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: migrate deployment parameter page to Angular and update to version 17.1 #739
Conversation
Please rebase to resolve the conflicts and fix the test |
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.html
Outdated
Show resolved
Hide resolved
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.spec.ts
Show resolved
Hide resolved
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.html
Outdated
Show resolved
Hide resolved
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.ts
Outdated
Show resolved
Hide resolved
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.ts
Outdated
Show resolved
Hide resolved
AMW_rest/src/main/java/ch/mobi/itc/mobiliar/rest/deployments/DeploymentsRest.java
Outdated
Show resolved
Hide resolved
AMW_rest/src/main/java/ch/mobi/itc/mobiliar/rest/deployments/DeploymentsRest.java
Outdated
Show resolved
Hide resolved
AMW_rest/src/main/java/ch/mobi/itc/mobiliar/rest/deployments/DeploymentsRest.java
Outdated
Show resolved
Hide resolved
AMW_rest/src/main/java/ch/mobi/itc/mobiliar/rest/deployments/DeploymentsRest.java
Outdated
Show resolved
Hide resolved
…n deployment parameter component
…arameter' into feature/737-angular-deployment-parameter
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.ts
Outdated
Show resolved
Hide resolved
AMW_angular/io/src/app/settings/deployment-parameter/deployment-parameter.component.html
Outdated
Show resolved
Hide resolved
Yes that's ok. The name is a bit misleading, the old permissions are global and the new are per resource, env etc. It's more like permissions are from the old (global) or new (scoped) permission concept. |
When I try to add a duplicate tag, the error toast sometimes shows for a short time only (less than a second, sometime it just blinks). The only reliable way I found to reproduce this spamming the add button with the same tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me now, thanks!
The toast still has a strange behaviour. It looks like the timer on the component keeps running even if a new toast is show (replacing the old before it's time) and then the old timer closes the new toast. Timer:
setTimeout(() => { |
May the old timer has to be canceled or it should only hide the toast if it matches the toast.
Should we merge this and you have a look in a separate issue?
We resolved the timeout issue with clearing the old one first. A improvement for the future would be, to show multiple toast instead of only one. Should we create a story for a toastContainer-Component? |
I created an new issue for it: #744 |
@yvespp while adding user permissions to deployment-parameter and tags components in Angular, I noticed that permissions are defined as either old or new (
AMW_business/src/main/java/ch/puzzle/itc/mobiliar/business/security/entity/Permission.java
). Do you know the reason why some are defined as old and some as new, and is it okay thatMANAGE_GLOBAL_TAGS
andMANAGE_DEPLOYMENT_PARAMETER
are old?