Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I analyzed the existing implementation for deployments affecting #353. I quickly realized that there would be a huge potential for refactorings, but often the test coverage is not sufficient to support efficient refactorings.
Writing new unit tests would be possible, but is often quite difficult due to the number of dependent services, repositories
and boundaries that must be mocked away. In addition, mocking all these dependencies actually makes it harder to refactor, since the mocks couple the test to the actual implementation.
Anyway. Having end-to-end tests that cover the main paths of the application would be helpful. There was an e2e test setup in the AMW_angular module. But:
So I removed Protractor from the AMW_angular module.
Then I decided to create a separate module for the end-to-end testing, because the whole application is affected, not just the parts implemented in Angular.
For now, this is just the setup with a very simple test to show, that the setup is correct.
This PR adds a dedicated Github Action Workflow to run the end-to-end tests. But there are lots of overlappings with the existing build and test action. The e2e tests could also be added to the existing workflow.
Please feel free to suggest changes, improvements or even reject this PR