Skip to content

Commit

Permalink
DELIA-65341 - getPublicIP is not returning proper value (rdkcentral#5331
Browse files Browse the repository at this point in the history
)

getPublicIP is not returning proper value

Reason for change: Without checking the null check, the config stun endpoint
and port value is being set. Added null condition check so that config value
is taken when it is non empty and default value will be taken when config
value is empty
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>
  • Loading branch information
gururaajar authored May 24, 2024
1 parent 8cefce1 commit 6644f86
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions NetworkManager/service/NetworkManagerImplementation.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ namespace WPEFramework

Stun()
: Core::JSON::Container()
, stunEndpoint(_T(""))
, port(19310)
, stunEndpoint(_T("stun.l.google.com"))
, port(19302)
, interval(30)
{
Add(_T("endpoint"), &stunEndpoint);
Expand Down

0 comments on commit 6644f86

Please sign in to comment.