-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add children to Dropdown props interface (#171)
* Add children to Dropdown props interface While attempting to import the `<Dropdown>` component from Flame in the new insights app (https://github.com/lightspeed-hospitality/lighthouse-insights), we ran into a Typescript issue where the app wouldn't compile because `children` was not a valid prop in the `Dropdown` interface. The insights app is using React 18 and in that version React.FC no longer includes children by default. - https://stackoverflow.com/a/71809927/16826114 - https://solverfox.dev/writing/no-implicit-children/ So any Flame components that use React.FC and a children prop will probably need to be updated to be compatible with React 18 and TS. For now we're making this one change in this one component we need as a way to kick the tires on contributing to Flame and to make sure it works as we expect. * Update CHANGELOG.md * Add documentation about using `yarn link` * Update CONTRIBUTING.md
- Loading branch information
1 parent
6055868
commit f38c060
Showing
3 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters