Fix datetime deserialization #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
reviewed
Oct 24, 2023
| @@ -284,8 +284,8 @@ def from_json(requester: Requester, obj: Mapping[str, Any]) -> PaymentRequestDat | |||
| ), | |||
| payment_hash=obj["invoice_data_payment_hash"], | |||
| amount=CurrencyAmount_from_json(requester, obj["invoice_data_amount"]), | |||
| created_at=obj["invoice_data_created_at"], | |||
| expires_at=obj["invoice_data_expires_at"], | |||
| created_at=datetime.fromisoformat(obj["invoice_data_created_at"]), | |||
There was a problem hiding this comment.
Looks like we may need to import datetime too?
There was a problem hiding this comment.
Of course! I missed it somehow :)
vdurmont
force-pushed
the
fix-datetime-deser
branch
from
620a0b6 to
40b7b26
Compare
vdurmont
force-pushed
the
fix-datetime-deser
branch
from
40b7b26 to
6dcee3f
Compare
jklein24
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to just get the string value from the JSON and store it in the field. Now we properly deserialize it using
datetime.fromisoformat.