Rust uniffi for ripcord #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-ramakrishnan
force-pushed
the
rohan_ripcord_sdk_uniffi
branch
from
090bb53 to
b663eb5
Compare
rohan-ramakrishnan
force-pushed
the
rohan_ripcord_sdk_uniffi
branch
from
b663eb5 to
e9e0b19
Compare
yellowred
approved these changes
Apr 11, 2024
zhenlu
reviewed
Apr 11, 2024
mhrheaume
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is not great really, but it works as is the same with the other ripcord stuff. It basically should be treated as a script that can ingest a kit and private key and can spit out the relevant results. It is not resilient to errors really, and does not have to be.
For now, we do not expose implementation details in errors. Depending on how this code gets used in sdks we can expose and let sdks handle this, but we don't need to do that either