Check for existing asset in db before attempting to insert a new asset. #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the QueryAssets SQL query with ID field filtering for anchored UTXO, genesis, and script key.
This was referenced Nov 20, 2023
ffranr
force-pushed
the
balance-bug-import-proofs
branch
from
71f9969 to
a51368f
Compare
jharveyb
approved these changes
Nov 20, 2023
@jharveyb yes, I would like to refactor the custodian in another PR. It doesn't handle the events cache very cleanly. |
Yep, this also needs to be resolved. We have some candidate fixes in mind, and can exercise the fixes at the unit test level. |
Roasbeef
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another solution for #665 .
In these commits we add a check to ensure that if a confirmed asset already exists in our db we do not attempt to insert another copy.
This solution is a better solution than #684 because it is simpler and less risky.