Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove num assets from universe Info call #647

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Nov 2, 2023

The call it just used as a quick sanity check, so doesn't need to depend on a potentially expensive db transaction.

Fixes #643

@Roasbeef Roasbeef force-pushed the remove-stats-from-info branch from 434d1cd to 3beb93c Compare November 2, 2023 18:53
@Roasbeef Roasbeef requested a review from jharveyb November 2, 2023 18:53
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM - Could update after the stats rework.

The call it just used as a quick sanity check, so doesn't need to depend
on a potentially expensive db transaction.

Fixes lightninglabs#643
@Roasbeef Roasbeef force-pushed the remove-stats-from-info branch from 3beb93c to ce0d533 Compare November 2, 2023 23:36
@Roasbeef Roasbeef merged commit 1e24b99 into lightninglabs:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Not adding server to federation
2 participants