build: prep for Go 1.22 by using GOEXPERIMENT=loopvar for tests #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we need to use an explicit version of Go in the |
Roasbeef
force-pushed
the
loop-scope-fix
branch
from
9658e56 to
665f4ef
Compare
|
Updated with that. Will land this if CI green, one less thing to have to think about when writing+reviewing code. |
This is needed so we can use `GOEXPERIMENT=loopvar`.
In this commit, [we prep for some upcoming changes in Go](https://go.dev/blog/loopvar-preview) by running our tests with `GOEXPERIMENT=loopvar`. This changes the loop semantics to fix a common bug where a scoping issue causes a variable to be re-used, which can cause unintended bugs down the line. If everything passes with this flag on, then we can keep it on, and also rest a bit easier knowing that the compiler will fix a class of bugs that would previously pop up for us.
The prior commit made sure that no unit tests failed with the new logic applied. We'll also update our build+install commands so all the binaries are built with the new loop semantics.
Roasbeef
force-pushed
the
loop-scope-fix
branch
from
c796ba2 to
79c0a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we prep for some upcoming changes in
Go by running our tests with
GOEXPERIMENT=loopvar. This changes the loop semantics to fix a commonbug where a scoping issue causes a variable to be re-used, which can
cause unintended bugs down the line.
If everything passes with this flag on, then we can keep it on, and also
rest a bit easier knowing that the compiler will fix a class of bugs
that would previously pop up for us.