tapgarden: use lru.Cache for various new group caches #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
group-cache-lru
branch
from
69615bb to
10021e0
Compare
Roasbeef
commented
Oct 3, 2023
| @@ -1381,12 +1400,14 @@ func GenRawGroupAnchorVerifier(ctx context.Context) func(*asset.Genesis, | |||
| return ErrGenesisNotGroupAnchor | |||
| } | |||
|
|
|||
| groupAnchors[assetGroupKey] = gen | |||
There was a problem hiding this comment.
So here groupAnchor wasn't re assigned.
There was a problem hiding this comment.
Ah returns nil anyway, so np.
Roasbeef
commented
Oct 3, 2023
| // cache. This should be used when the cache just needs to worry aobut the | ||
| // total number of elements, and not also the size (in bytes) of the elements. | ||
| type singleCacheValue[T any] struct { | ||
| val T |
There was a problem hiding this comment.
You can't embed type param values, so had to use this here.
Roasbeef
commented
Oct 3, 2023
|
|
||
| // emptyCacheVal is a type def for an empty cache value. In this case the cache | ||
| // is used more as a set. | ||
| type emptyCacheVal = singleCacheValue[emptyVal] |
There was a problem hiding this comment.
Type alias used here to it inherits all the methods.
This also fixes a bug in `GenRawGroupAnchorVerifier` where the `groupAnchor` value wasn't being properly re assigned.
Roasbeef
force-pushed
the
group-cache-lru
branch
from
10021e0 to
111042f
Compare
jharveyb
reviewed
Oct 3, 2023
| var verifierLock sync.Mutex | ||
| groupAnchors := lru.NewCache[ | ||
| asset.SerializedKey, singleCacheValue[*asset.Genesis]]( | ||
| assetGroupCacheSize, |
There was a problem hiding this comment.
IIUC with a 10k element cache this would be a few MB max?
jharveyb
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug in
GenRawGroupAnchorVerifierwhere thegroupAnchorvalue wasn't being properly re assigned.