Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapfreighter: validate proof courier address before commencing send #497

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Sep 11, 2023

This PR closes issue #455 .

@ffranr ffranr self-assigned this Sep 11, 2023
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tapfreighter/chain_porter.go Outdated Show resolved Hide resolved
@ffranr ffranr force-pushed the validate-proof-courier-addrs branch 2 times, most recently from eadcf26 to 5f0a474 Compare September 12, 2023 14:51
@ffranr ffranr force-pushed the validate-proof-courier-addrs branch from 5f0a474 to 01a9172 Compare September 12, 2023 14:57
@ffranr
Copy link
Contributor Author

ffranr commented Sep 12, 2023

@positiveblue Thanks for the review!

I think I've found a better methodology for this change. I've updated the PR, apologies for the late change.

@ffranr ffranr requested a review from positiveblue September 12, 2023 15:02
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new approach more, we could incorporate something like this in our rpc flows too 💯

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💣

@Roasbeef Roasbeef merged commit 89837b8 into main Sep 12, 2023
14 checks passed
@guggero guggero deleted the validate-proof-courier-addrs branch October 11, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants