Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename aperture courier type to hashmail courier type #493

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Sep 7, 2023

Aperture is the service. The courier type enum should organise supported courier address protocols.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ffranr ffranr self-assigned this Sep 7, 2023
@ffranr ffranr requested a review from positiveblue September 7, 2023 15:09
Copy link
Collaborator

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@guggero
Copy link
Member

guggero commented Sep 8, 2023

Can be rebased now to get the CI passing.

@ffranr ffranr force-pushed the rename-aperture-courier-type branch from 6e3bf67 to 19930a9 Compare September 8, 2023 14:16
@guggero guggero enabled auto-merge September 8, 2023 14:19
@guggero guggero added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 9628583 Sep 8, 2023
14 checks passed
@guggero guggero deleted the rename-aperture-courier-type branch September 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants