tapgarden: minter perf fixes #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
force-pushed
the
minter_perf_fixes
branch
from
da9a22f to
fc8a466
Compare
jharveyb
force-pushed
the
minter_perf_fixes
branch
from
10efcc4 to
81c564a
Compare
|
I think these optimizations are still relevant? cc @positiveblue |
|
Sort of, I think the caching header verifier is but that isn't evident when using a network with empty blocks like the itest conditions. After further testing I don't think the script key parallel calls are really relevant. I think the (more complex) bottleneck is the proof insertion & DB operations that happen after TX confirmation, but there are pending PRs for batch insertion now. Would be good to get data on perf before & after those changes. |
|
Mostly replaced by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #314 and #315.
Implements a header verifier that caches the correct block hash instead making multiple RPC calls for each minting proof generated, and also moves some slower methods in the sprout creation loop into separate goroutines.
It would be better to use a
threadPoolthere instead of starting & stopping the goroutines manually. I think at this point the sprout creation loop is current bottlenecked on key tweaking for new group keys, but not entirely sure.