Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint with external asset group PSBT signer #1210

Closed
wants to merge 3 commits into from

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 21, 2024

This PR updates the ChainPlanter to enable the extraction of data required for an external signer to generate and produce the asset group witness.

This is a work in progress, and I am seeking early feedback on the approach. It follows the solution implementation proposed here: #1207

I think SeedlingExternalSealPkg should contain everything that the external signer needs to sign the PSBT.

Extract method `isBatchSealed` from the `sealBatch` method to improve
clarity and reusability.
Simplifies the code by ensuring the consistency check for group requests
and virtual transactions is handled within the buildGroupReqs function.
This removes redundant checks from multiple call sites.
…seal package for a given batch

This package can be used for external asset group witness PSBT signing.
@ffranr ffranr requested a review from guggero November 21, 2024 16:56
@ffranr ffranr self-assigned this Nov 21, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11957954846

Details

  • 35 of 89 (39.33%) changed or added relevant lines in 1 file are covered.
  • 37 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.04%) to 41.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapgarden/planter.go 35 89 39.33%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
asset/mock.go 3 92.2%
commitment/tap.go 4 84.17%
tapdb/multiverse.go 6 68.21%
asset/asset.go 6 80.79%
tapgarden/planter.go 8 71.95%
tapgarden/caretaker.go 8 68.87%
Totals Coverage Status
Change from base Build 11955833805: -0.04%
Covered Lines: 25562
Relevant Lines: 62046

💛 - Coveralls

@ffranr
Copy link
Contributor Author

ffranr commented Nov 22, 2024

We can probably close this in favour of #1214

@guggero
Copy link
Member

guggero commented Nov 28, 2024

We can probably close this in favour of #1214

Yes, I agree. Looks like #1214 is farther along.

@guggero guggero removed their request for review November 28, 2024 13:14
@ffranr ffranr closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants