Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LitD itest CI #1193

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix LitD itest CI #1193

merged 1 commit into from
Nov 15, 2024

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR fixes a typo in the go.mod replace directive for the taproot-assets dependency

@GeorgeTsagk GeorgeTsagk self-assigned this Nov 14, 2024
@dstadulis dstadulis added this to the v0.5 (v0.4.2 rename) milestone Nov 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11842214719

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 41.044%
Files with Coverage Reduction New Missed Lines %
commitment/tap.go 1 84.7%
tappsbt/create.go 2 53.22%
tapchannel/aux_leaf_signer.go 2 35.92%
tapgarden/caretaker.go 8 68.5%
universe/interface.go 12 50.22%
Totals Coverage Status
Change from base Build 11829805032: 0.01%
Covered Lines: 25172
Relevant Lines: 61329
💛 - Coveralls

Roasbeef
Roasbeef approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚣🏽‍♀️

@Roasbeef Roasbeef merged commit 9fb3872 into lightninglabs:main Nov 15, 2024
17 of 18 checks passed
@guggero
Copy link
Member

guggero commented Nov 15, 2024

Post merge ACK, thanks for the fix!

@GeorgeTsagk GeorgeTsagk removed the request for review from ellemouton November 15, 2024 08:55
gijswijs pushed a commit that referenced this pull request Nov 20, 2024
@Roasbeef @gijswijs
Merge pull request #1193 from GeorgeTsagk/ci-litd-itest-fix
fb935d1 
Fix LitD itest CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstadulis dstadulis dstadulis approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@GeorgeTsagk @coveralls @guggero @Roasbeef @dstadulis