Fee bumping when fee estimation doesn't meet min relay fee #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11952886458Details
💛 - Coveralls |
|
itest failing due to feeEstimation changes |
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
9c745bd to
454ea22
Compare
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
454ea22 to
dfc0a23
Compare
jharveyb
reviewed
Nov 15, 2024
gijswijs
force-pushed
the
min-relay-fee-bump
branch
2 times, most recently
from
882d026 to
8325301
Compare
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
8325301 to
d410b47
Compare
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
d410b47 to
1159a3f
Compare
Famous last words. 😄 Anyways, I've changed both Please also have a look at Lines 685 to 686 in 1159a3f If I'm right we could remove a check there. |
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
1159a3f to
d0d7417
Compare
jharveyb
approved these changes
Nov 21, 2024
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
d0d7417 to
409b018
Compare
This commit includes a minrelayfee check in `checkFeeRateSanity` so that we can err fast if a manually provided feerate doesn't meet minrelayfee.
If the fee estimation returns a fee rate lower than the min relay fee, we should use the min relay fee instead. This commit implements this behavior for the minting transaction.
If the fee estimation returns a fee rate lower than the min relay fee, we should use the min relay fee instead. This commit implements this behavior for the tapfreighter.
The `testMinRelayFeeBump` itest checks that the minting transaction and a basic send obtain a fee bump when the min relay fee is increased to a value that is higher than the fee estimation. fix
gijswijs
force-pushed
the
min-relay-fee-bump
branch
from
409b018 to
b9a64f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the minting transaction and normal on chain transactions suffer from edge cases where the fee estimation comes up with a fee that doesn't meet the current min relay fee. This PR changes that behavior by checking the estimated fee against the min relay fee, and bumps the fee if it doesn't clear the minimum fee height implied by min relay fee.
fixes #1171