Skip to content

Commit

Permalink
Merge pull request #491 from lightninglabs/fix-docker-build
Browse files Browse the repository at this point in the history
Fix docker build
  • Loading branch information
guggero authored Sep 7, 2023
2 parents c8bed24 + 92351ac commit aafd6c8
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 8 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,33 @@ jobs:
- name: compile code
run: go install -v ./...

########################
# Docker build check.
########################
docker-build-check:
name: Docker build check
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3

- name: Set up QEMU
uses: docker/setup-qemu-action@v2

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Build default image
uses: docker/build-push-action@v4
with:
tags: "default-taproot-assets"

- name: Build dev image
uses: docker/build-push-action@v4
with:
file: dev.Dockerfile
tags: "dev-taproot-assets"

########################
# cross compilation
########################
Expand Down
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "bips"]
path = bips
url = git@github.com:Roasbeef/bips.git
url = https://github.com/Roasbeef/bips.git
branch = bip-tap
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# /make/builder.Dockerfile
# /taprpc/Dockerfile
# /tools/Dockerfile
FROM golang:1.21.0-bookworm as builder
FROM golang:1.21.0-alpine as builder

# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
# queries required to connect to linked containers succeed.
Expand Down
9 changes: 5 additions & 4 deletions itest/tapd_harness.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"os"
"path/filepath"
"sync"
"testing"
"time"

"github.com/btcsuite/btcd/chaincfg"
Expand Down Expand Up @@ -78,7 +79,7 @@ type tapdConfig struct {

// newTapdHarness creates a new tapd server harness with the given
// configuration.
func newTapdHarness(ht *harnessTest, cfg tapdConfig,
func newTapdHarness(t *testing.T, ht *harnessTest, cfg tapdConfig,
proofCourier proof.CourierHarness,
proofSendBackoffCfg *proof.BackoffCfg,
proofReceiverAckTimeout *time.Duration) (*tapdHarness, error) {
Expand Down Expand Up @@ -117,11 +118,11 @@ func newTapdHarness(ht *harnessTest, cfg tapdConfig,

case tapcfg.DatabaseBackendPostgres:
fixture := tapdb.NewTestPgFixture(
ht.t, *postgresTimeout, !*noDelete,
t, *postgresTimeout, !*noDelete,
)
ht.t.Cleanup(func() {
t.Cleanup(func() {
if !*noDelete {
fixture.TearDown(ht.t)
fixture.TearDown(t)
}
})
tapCfg.DatabaseBackend = tapcfg.DatabaseBackendPostgres
Expand Down
2 changes: 1 addition & 1 deletion itest/test_harness.go
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ func setupTapdHarness(t *testing.T, ht *harnessTest,
}

tapdHarness, err := newTapdHarness(
ht, tapdConfig{
t, ht, tapdConfig{
NetParams: harnessNetParams,
LndNode: node,
}, selectedProofCourier,
Expand Down

0 comments on commit aafd6c8

Please sign in to comment.