Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RawClientWithMacAuth to each client #190

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 24, 2024

This allows us to use the underlying RPC methods directly while still taking advantage of the macaroon management.

Using the raw RPC methods directly can be useful when a new method isn't implemented in lndclient yet or when we want to pass the raw RPC request method directly instead of converting it to the lndclient structs.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@guggero guggero requested review from bhandras and ellemouton July 24, 2024 16:04
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, uTACK 🎉

@guggero guggero force-pushed the lndclient-raw-client branch from a676c76 to cf9a271 Compare July 24, 2024 16:22
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@guggero guggero merged commit 64a756a into custom-channels-integration Jul 25, 2024
1 check passed
@guggero guggero deleted the lndclient-raw-client branch July 25, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants