Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walletkit: add startHeight parameter to ListSweeps and ListSweepsVerbose #175

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

bhandras
Copy link
Member

@bhandras bhandras commented Feb 7, 2024

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@bhandras bhandras changed the base branch from master to lnd-17-0 February 7, 2024 17:27
@bhandras bhandras requested a review from guggero February 7, 2024 17:27
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but need to bump the minimum version requirement as it won't be backward compatible (or fail with weird side effects because the new parameter is just ignored by old versions).

walletkit_client.go Show resolved Hide resolved
@bhandras bhandras changed the base branch from lnd-17-0 to lnd-17-4 February 8, 2024 12:55
@bhandras bhandras force-pushed the listsweeps-startheight branch from 674c027 to 314ecc0 Compare February 8, 2024 12:56
@bhandras bhandras requested a review from guggero February 8, 2024 12:57
@guggero guggero merged commit f6c6471 into lnd-17-4 Feb 8, 2024
1 check passed
@bhandras bhandras deleted the listsweeps-startheight branch February 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants