client: implemented messaging signing.

[ardevd]

added support for the main RPC implementation of message signing.

[guggero]

Thanks for the PR!

[bhandras]

I believe you need to update permissions.json to make the test pass.
Other than that LGTM 🎉

[ardevd]

I believe you need to update permissions.json to make the test pass. Other than that LGTM 🎉

Not entirely sure what update is needed to permissions.json. Something like:

"/lnrpc.Lightning/Signmessage": {
            "permissions": [
                {
                    "entity": "onchain",
                    "action": "read"
                }
            ]
        },

?

[guggero]

Yes, that should be enough.

[ardevd]

Actually, on further inspection, a similar block is already present in permissions.json.

"/lnrpc.Lightning/SignMessage": {
            "permissions": [
                {
                    "entity": "message",
                    "action": "write"
                }
            ]
        },

on line 563

[guggero]

Ah, I think you need to bump Line 15 in

lndclient/macaroon_recipes_test.go

Line 15 in 2005b0d

"lnrpc": 11,

.
Since a new permission is now being used by the lndclient.