Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnc-core: update version to v0.3.2-alpha #37

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ViktorTigerstrom
Copy link
Collaborator

This PR bumps lnc-core to v0.3.2-alpha.

@ViktorTigerstrom ViktorTigerstrom changed the title lnc-core: update version to `v0.3.2-alpha lnc-core: update version to v0.3.2-alpha Jul 26, 2024
package.json Outdated Show resolved Hide resolved
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release tags in the package.json file are only used to download the protos that are compatible with the corresponding litd version. We don't need to be 100% precise on the exact commit hash, as long as the protos match.

package.json Outdated Show resolved Hide resolved
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2024-07-bump-version-to-v.0.3.2-alpha branch from e40d50a to 27ef73a Compare July 29, 2024 09:50
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested this and lightninglabs/lnc-web#114 together via TW. It all works great.

@ViktorTigerstrom
Copy link
Collaborator Author

Thanks for the review @jamaljsr! Merging

@ViktorTigerstrom ViktorTigerstrom merged commit 5159eea into main Jul 29, 2024
3 checks passed
@jamaljsr jamaljsr deleted the 2024-07-bump-version-to-v.0.3.2-alpha branch September 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants