Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: fix typos #924

Merged
merged 1 commit into from
Dec 26, 2024
Merged

multi: fix typos #924

merged 1 commit into from
Dec 26, 2024

Conversation

Pricstas
Copy link
Contributor

This pull request corrects several typos in the following files:

  • appStorage.spec.ts: Changed "an value" to "a value" to fix an article usage error.
  • log.spec.ts: Corrected "a error log message" to "an error log message" for proper article usage.
  • appView.ts: Fixed "adds a alert" to "adds an alert" to ensure correct article usage.
  • client.go: Corrected "returns a autopilot-server client" to "returns an autopilot-server client" to fix article usage.

These changes improve the consistency and accuracy of the code.

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pricstas!

Please squash all commits into a single commit with the title:
"multi: fix typos"

@Pricstas Pricstas changed the title Fix typos multi: fix typos Dec 19, 2024
@ViktorTigerstrom
Copy link
Contributor

Hi again @Pricstas,

I noticed that you've updated the PR title, so I just wanted to clarify my previous comment:

Currently, the PR consists of four different commits. My suggestion was to squash all four commits into a single commit and then reword the title of that commit to:
"multi: fix typos"

If you're unsure how to squash commits into a single commit, the following guide might be helpful:
https://medium.com/@vanshbadkul/squashing-commits-in-git-a-step-by-step-guide-884581224adf

@Pricstas
Copy link
Contributor Author

Hi @ViktorTigerstrom ,

I've squashed all four commits into a single one and updated the commit title to "multi: fix typos" as suggested.
Let me know if everything looks good now.

@ViktorTigerstrom
Copy link
Contributor

Thanks @Pricstas ! Looks good! We'll proceed with merging of this in the beginning of January.

@guggero guggero merged commit 1902ebb into lightninglabs:master Dec 26, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants