Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapd: add new CLI command for decodeassetinvoice along with corresponding itest for DecodeAssetPayReq #923

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

Roasbeef
Copy link
Member

No description provided.

@dstadulis dstadulis added this to the tapd v0.5 milestone Dec 15, 2024
@Roasbeef Roasbeef changed the title tapd: add new CLI command for decodeassetinvoice along with corresponding itest for `DecodeAssetPayReq tapd: add new CLI command for decodeassetinvoice along with corresponding itest for DecodeAssetPayReq Dec 15, 2024
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cmd/litcli/ln.go Outdated Show resolved Hide resolved
cmd/litcli/ln.go Outdated Show resolved Hide resolved
cmd/litcli/ln.go Show resolved Hide resolved
itest/litd_custom_channels_test.go Outdated Show resolved Hide resolved
@GeorgeTsagk
Copy link
Member

needs a go.mod replace to point to lightninglabs/taproot-assets#1253

@guggero guggero force-pushed the update-to-lnd-18-4 branch 2 times, most recently from d59c717 to 76e65f1 Compare December 16, 2024 14:54
@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch 3 times, most recently from 51d4166 to cd8890b Compare December 17, 2024 14:08
@guggero guggero force-pushed the update-to-lnd-18-4 branch 2 times, most recently from b674ce2 to 411f881 Compare December 17, 2024 20:32
@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch 2 times, most recently from ab21715 to 3b68a35 Compare December 18, 2024 16:41
go.mod Outdated
@@ -23,7 +23,7 @@ require (
github.com/lightninglabs/pool v0.6.5-beta.0.20241015105339-044cb451b5df
github.com/lightninglabs/pool/auctioneerrpc v1.1.2
github.com/lightninglabs/pool/poolrpc v1.0.0
github.com/lightninglabs/taproot-assets v0.5.0-rc2.0.20241217185126-a9a2744061f1
github.com/lightninglabs/taproot-assets v0.5.0-rc2.0.20241218162444-57c2454c050e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dep branch must be rebased in order to build

@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch from 3b68a35 to 4281f22 Compare December 18, 2024 17:46
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM pending linter fixes.

itest/litd_custom_channels_test.go Outdated Show resolved Hide resolved
@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch from 4281f22 to 002479e Compare December 19, 2024 11:52
@guggero guggero merged commit 95faab7 into update-to-lnd-18-4 Dec 19, 2024
8 of 13 checks passed
@guggero guggero deleted the decode-asset-pay-req-itest branch December 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants