itest: expect failure on direct rfq peer btc invoices

[GeorgeTsagk]

Description

Previously we'd consider it acceptable to settle direct rfq peer
invoices, which included no rfq scid, with asset HTLCs. This behavior
has been updated on the tapd invoice manager and we no longer accept
asset HTLCs on invoices that do not expect assets. This commit updates
such payments in our itests to instead expect a failure.

Tapd dependency: lightninglabs/taproot-assets#1244
Lnd dependency: lightningnetwork/lnd#9357

[guggero]

itest seems to fail.

[GeorgeTsagk]

itest seems to fail.

interesting, could be flaky, didn't hit this on local tests

[GeorgeTsagk]

also linter seems to fail here with
https://github.com/lightninglabs/lightning-terminal/actions/runs/12275164256/job/34257220772?pr=916#step:5:293

go: github.com/lightninglabs/lightning-terminal imports
	github.com/lightningnetwork/lnd/kvdb imports
	github.com/lightningnetwork/lnd/kvdb/etcd imports
	go.etcd.io/etcd/server/v3/embed: mkdir /home/runner/go/pkg/mod/cache/download/go.etcd.io/etcd/server: permission denied

passes locally

[ffranr]

👍 need to remove the temp commit (waiting on dep I guess?), otherwise looks good.

[GeorgeTsagk]

thanks @ffranr , currently working on resolving an error with the htlc force-close test, will push once it has been resolved

[guggero]

LGTM pending dependant PRs and nit mentioned in earlier review.

[guggero]

Can be updated to lnd commit 04767fe which will remain stable, even after tagging the RC.

[GeorgeTsagk]

Updated go.mod deps & rebased
Waiting for CI

[guggero]

Just FYI: The itests broke due to the update to the latest tapd version on the base branch (update-to-lnd-18-4), will take a look. So the CI on this will likely also fail.

[guggero]

Ah, actually, this PR fixes the CI (which makes sense). So I cherry picked the relevant commit into the base branch (update-to-lnd-18-4) itself, which means this can be closed.