Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated boolean in .vscode with string value #897

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

gijswijs
Copy link
Contributor

@gijswijs gijswijs commented Nov 7, 2024

The boolean values for source.fixAll.eslint are deprecated. This
commit changes the boolean values to the correct string values.

See: https://code.visualstudio.com/updates/v1_83#_editor

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

.vscode/settings.json Outdated Show resolved Hide resolved
The boolean values for `source.fixAll.eslint` are deprecated. This
commit changes the boolean values to the correct string values.

See: https://code.visualstudio.com/updates/v1_83#_editor
@sputn1ck sputn1ck self-requested a review November 8, 2024 18:19
Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

@guggero guggero merged commit 9ad3f06 into master Nov 8, 2024
12 of 13 checks passed
@guggero guggero deleted the vscode-update branch November 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants