Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lnd compile time dependency to v0.17.0, update RPC compilation of test proto #139

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 21, 2024

Replaces #138.

@starius
Copy link
Contributor

starius commented Jun 21, 2024

When I run make fmt in the branch, it results in this diff:

diff --git a/pricesrpc/prices.pb.json.go b/pricesrpc/prices.pb.json.go
index 8750a9f..423334e 100644
--- a/pricesrpc/prices.pb.json.go
+++ b/pricesrpc/prices.pb.json.go
@@ -1,6 +1,7 @@
 // Code generated by falafel 0.9.1. DO NOT EDIT.
 // source: prices.proto
 
+//go:build js
 // +build js
 
 package pricesrpc

I use Go go1.22.4

Copy link
Contributor

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

One nit about make fmt

@guggero
Copy link
Member Author

guggero commented Jun 21, 2024

Hmm, that file is auto generated by falafel. I guess we should update that to use the new format.
If I manually format the file then the RPC check CI step will fail. So I'll leave it for now and see if I have time to update falafel at some point. But thanks for noticing!

@lightninglabs-deploy
Copy link
Collaborator

@ViktorTigerstrom: review reminder

@Roasbeef Roasbeef merged commit 4c45bdd into lightninglabs:master Jul 3, 2024
5 checks passed
@guggero guggero deleted the lnd-17 branch July 8, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants