Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod+linter: fix go.opentelemetry.io dependency bump #123

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Nov 28, 2023

Replaces #119 which was auto created by Dependabot but caused compile time and linter issues.

dependabot bot and others added 3 commits November 20, 2023 18:30
…golang.org/grpc/otelgrpc

Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.25.0 to 0.46.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.25.0...zpages/v0.46.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
The automatic version bump created by Dependabot caused a compile time
issue and an issue with the linter.
Bumping the other go.opentelemetry.io dependencies seems to fix that.
Not strictly necessary to fix the linter issues caused by the version
bump, but nice to have.
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙏

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@guggero guggero merged commit df19ef5 into master Nov 28, 2023
5 checks passed
@guggero guggero deleted the opentelemetry-fix branch November 28, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants