Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fee Estimation Docs #277

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Beige-Coffee
Copy link
Contributor

@Beige-Coffee Beige-Coffee commented Aug 26, 2024

This PR updates the Fee Estimation docs, incorporating the new ConfirmationTargets outlined in this PR.

Changes are the following:

  1. Updated the ConfirmationTarget table with new Confirmation Targets (MaximumFeeEstimate, UrgentOnChainSweep)
  2. Added commentary to Best Practices and Off-Chain sections regarding how to understand and populate MaximumFeeEstimate.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for lightningdevkit ready!

Name Link
🔨 Latest commit 399ca1c
🔍 Latest deploy log https://app.netlify.com/sites/lightningdevkit/deploys/66da3efcbc31af0008c5fb65
😎 Deploy Preview https://deploy-preview-277--lightningdevkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Beige-Coffee Beige-Coffee marked this pull request as ready for review September 5, 2024 23:38
@Beige-Coffee
Copy link
Contributor Author

@ConorOkus & @jkczyz - just giving a heads up that I updated the Fee Estimation docs per Matt's PR from a week or so ago.

I have one question for the group (+ @TheBlueMatt): Does anyone have suggestions regarding the MaximumFeeEstimate entry in the ConfirmationTarget table? Currently, I've added the below. If there are no suggestions, then we should be good to go!

ConfirmationTarget mempool.space Category Number of Blocks
MaximumFeeEstimate fastestFee 1

@ConorOkus ConorOkus merged commit d16c740 into lightningdevkit:main Oct 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants