Ian/cxx common action #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
reviewed
Jun 1, 2023
Comment on lines
+39
to
+48
| mono `./vcpkg/vcpkg fetch nuget | tail -n 1` \ | ||
| sources add \ | ||
| -source "https://nuget.pkg.github.com/lifting-bits/index.json" \ | ||
| -storepasswordincleartext \ | ||
| -name "GitHub" \ | ||
| -username "lifting-bits" \ | ||
| -password "${{ inputs.gh-token }}" | ||
| mono `./vcpkg/vcpkg fetch nuget | tail -n 1` \ | ||
| setapikey "${{ inputs.gh-token }}" \ | ||
| -source "https://nuget.pkg.github.com/lifting-bits/index.json" |
There was a problem hiding this comment.
Very weird it's still not working... In cxx-common, we add first and then update... I forget if that was for a special reason, like self-hosted runners, or if the authentication is finicky
https://github.com/lifting-bits/cxx-common/blob/94533d40904afb26ac979a8c91282f89f3c81fe3/.github/workflows/vcpkg_ci_amd64.yml#L98-L111
also, I run vcpkg from the same shell as the one I authenticate in
https://github.com/lifting-bits/cxx-common/blob/94533d40904afb26ac979a8c91282f89f3c81fe3/.github/workflows/vcpkg_ci_amd64.yml#L117
ekilmer
reviewed
Jun 1, 2023
actions/build-cxx-common/action.yml
Outdated
| working-directory: cxx-common | ||
| shell: "bash" | ||
| run: > | ||
| ./vcpkg/vcpkg install sqlite3 cpprestsdk |
There was a problem hiding this comment.
Suggested change
| ./vcpkg/vcpkg install sqlite3 cpprestsdk | |
| ./vcpkg/vcpkg install sqlite3 cpprestsdk --debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.