Take instructors directly to the class config on LTI login.

liffiton · Jul 22, 2024 · 9a57351 · 9a57351
1 parent a701df3
commit 9a57351
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/gened/lti.py b/src/gened/lti.py
@@ -121,7 +121,10 @@ def lti_login(lti: LTI) -> Response | tuple[str, int]:  # noqa: ARG001 (unused a
     set_session_auth_role(role_id)
 
     # Redirect to the app
-    return redirect(url_for("helper.help_form"))
+    if role == "instructor":
+        return redirect(url_for("class_config.config_form"))
+    else:
+        return redirect(url_for("helper.help_form"))
 
 
 @bp.route("/config.xml")

diff --git a/tests/test_lti.py b/tests/test_lti.py
@@ -85,7 +85,10 @@ def test_lti_auth_success(client, role, internal_role):
     assert "LTI communication error" not in result.text
     # success == redirect to help page...
     assert result.status_code == 302
-    assert result.location == '/help/'
+    if internal_role == 'instructor':
+        assert result.location == '/instructor/config/'
+    else:
+        assert result.location == '/help/'
 
     result = client.get('/help/')
     assert result.status_code == 200