-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Updates GET workflows to v3 #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielboloc
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
s0rthak
reviewed
Jan 16, 2025
s0rthak
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @s0rthak for your review comments! I've added the changes you suggested.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates GET workflows endpoint from v1 to v3.
Jira
https://lifebit.atlassian.net/browse/LIF-1346
Changes
Cloudos.get_workflow_list
method:for
loop instead of recursively for efficiencyCloudos.get_curated_workflow_list
method:getByType
. Now it uses search and we need to search thegroups
property.Cloudos.process_workflow_list
method:isModule
andparameters
are no longer available. Instead, the function now capturesgroup
which will be used to identifymodule
pipelines (system-tools, data-factory,...)Cloudos.is_module
method:isModule
is not returned by the server, so the method is modified to usegroup
value insteadJob.fetch_cloudos_id
method:Tests
Using docker image:
Global variables:
Get workflows list (default: only some fields and in CSV format)
Get workflows list (--all-fields: all available fields and in CSV format)
Get workflows list (--output-format json: all fields and in JSON format)
Get curated workflows list
Run a normal job
Run a normal job from a system-tool selecting latest Nextflow version and another queue (two warnings will appear as it is not allowed to change the Nextflow version or the queue for a system-tool)