Add memory effects for check ops (#877)

libxsmm · Feb 2, 2024 · bbce5a8 · bbce5a8
1 parent 0c5f14e
commit bbce5a8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/include/TPP/Dialect/Check/CheckOps.h b/include/TPP/Dialect/Check/CheckOps.h
@@ -12,6 +12,7 @@
 #include "mlir/IR/BuiltinTypes.h"
 #include "mlir/IR/Dialect.h"
 #include "mlir/IR/OpDefinition.h"
+#include "mlir/Interfaces/SideEffectInterfaces.h"
 
 #define GET_OP_CLASSES
 #include "TPP/Dialect/Check/CheckOps.h.inc"

diff --git a/include/TPP/Dialect/Check/CheckOps.td b/include/TPP/Dialect/Check/CheckOps.td
@@ -6,6 +6,7 @@
 #define CHECK_DIALECT_CHECK_OPS
 
 include "mlir/IR/OpBase.td"
+include "mlir/Interfaces/SideEffectInterfaces.td"
 
 def CHECK_Dialect : Dialect {
   let name = "check";
@@ -15,7 +16,8 @@ def CHECK_Dialect : Dialect {
   }];
 }
 
-def CHECK_ExpectTrueOp : Op<CHECK_Dialect, "expect_true"> {
+def CHECK_ExpectTrueOp : Op<CHECK_Dialect, "expect_true",
+    [MemoryEffects<[MemWrite, MemRead]>]> {
   let summary = [{Checks that the operand is true}];
   let description = [{
     Verifies that the operand contains a true value, which is represented by
@@ -39,7 +41,8 @@ def CHECK_ExpectAlmostEqOp :
     Op<CHECK_Dialect, "expect_almost_eq",
     [TypesMatchWith<"Operand types match",
                     "lhs", "rhs",
-                    "$_self.cast<ShapedType>()">]> {
+                    "$_self.cast<ShapedType>()">,
+    MemoryEffects<[MemWrite, MemRead]>]> {
   let summary = [{Checks that the operands are almost equal}];
   let description = [{
     Verifies that the tensor operands with float elements are
@@ -64,7 +67,7 @@ def CHECK_ExpectAlmostEqOp :
 }
 
 def CHECK_ExpectSaneOp :
-    Op<CHECK_Dialect, "expect_sane"> {
+    Op<CHECK_Dialect, "expect_sane", [MemoryEffects<[MemWrite, MemRead]>]> {
   let summary = [{Checks that the operand is neither NaN nor infinite}];
   let description = [{
     Verifies that the contents of tensor operand with float elements