Update Oracle database DBI parameter generation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
approved these changes
Apr 2, 2024
vectro
reviewed
Apr 2, 2024
lib/URI/oracle.pm
Outdated
| while (@p) { | ||
| push @kvpairs => join '=', shift @p, shift @p; | ||
| } | ||
| $dsn .= '?' . join ';' => @kvpairs; |
There was a problem hiding this comment.
Looking at the EZCONNECT syntax, it looks like parameters should be separated by &. Don't ask me what to do if a parameter or value contains &.
There was a problem hiding this comment.
Fixed in bfbd9f8, thanks.
|
Other than the |
Again. It now works as follows:
- If there is not a hostname or port, just use the raw SID or service
name as the database name: `dbi:Oracle:$name`. This is way 1 in the
DBD::Oracle documentation
- If there is a hostname or port, use the EZCONNECT syntax. This is
way 3 in the DBD::Oracle documentation.
- If there are query parameters, delimit them by `&` and not `;`.
Use of a port without a host name may not be valid, but it seems most
prudent to build an EZCONNECT that includes the port in this context and
to let Oracle or DBD::Oracle reject it if appropriate. Thanks again to
@vectro for the and diligence, testing, and patience with this issue
(#22).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again. It now works as follows:
name as the database name:
dbi:Oracle:$name. This is way 1 in theDBD::Oracle documentation
way 3 in the DBD::Oracle documentation.
Use of a port without a host name may not be valid, but it seems most prudent to build an EZCONNECT that includes the port in this context and to let Oracle or DBD::Oracle reject it if appropriate. Thanks again to @vectro for the and diligence, testing, and patience with this issue (resolves #22).