Change version numbers before 2.0 release #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "big change" here is the name change of the dll. I am not sure if we want to include the version number in the name. This is the job of a distribution or package builder I think. @sjaeckel will take care of the other changes regarding the version numbers. |
|
On other platforms than Windows - indeed - it is not customary to have a version number in the library name. On Windows it's normal (examples: ws2_32.dll, zlib1.dll, winsqlite3.dll, tcl86.dll, msvcr100.dll ...). Windows dll's simply don't have a suitable mechanism as other platforms do. |
minad
approved these changes
Dec 5, 2019
sjaeckel
reviewed
Jan 7, 2020
|
ping? |
czurnieden
approved these changes
Mar 10, 2020
|
This will only be merged right before the 2.0.0 release, so there's no need to rebase now. |
sjaeckel
approved these changes
Mar 10, 2020
Ah, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (microsoft) convension for dll's doesn't start with "lib" as on UNIX. So I suggest to use "tommath2.dll" as dll name. Also I made the other necessary corresponding makefile-related changes for the major upgrade.