Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt to fix #449 (ECDSA forcing DER/ASN.1) #450

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

An attempt to fix #449 (ECDSA forcing DER/ASN.1) #450

wants to merge 9 commits into from

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented Oct 14, 2018 •
edited by sjaeckel
Loading

This PR is incomplete (as I am not sure if it is the proper fix).

Cc: @sjaeckel @rmw42

TODO:

  • update doc
  • add a test case with eth27 signature format

@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch from ee8b8b5 to 7fda795 Compare October 14, 2018 16:26
@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch from 7fda795 to 41d9ee3 Compare October 26, 2018 17:53
@karel-m karel-m mentioned this pull request Oct 27, 2018
Closed
@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch from 41d9ee3 to 8e2b645 Compare November 7, 2018 08:13
sjaeckel
sjaeckel reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pk/ecc/ecc_sign_hash_rfc7518.c Show resolved Hide resolved
@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch from 8e2b645 to 5613bae Compare April 10, 2019 16:10
@sjaeckel
Copy link
Member

so we wait now until the two missing points are done?

@karel-m
Copy link
Member Author

karel-m commented Apr 10, 2019

If you agree with the proposed split, which I assume you do, I (or any other volunteer) have to update doc and tests.

@sjaeckel
Copy link
Member

👍

@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch 2 times, most recently from 797f10c to 9340721 Compare June 12, 2019 08:58
@sjaeckel sjaeckel force-pushed the pr/ecdsa-der-attempt1 branch from 9340721 to d1ac928 Compare January 22, 2020 09:48
@sjaeckel sjaeckel added this to the next milestone Oct 26, 2020
karel-m and others added 7 commits April 11, 2021 16:39
@karel-m
refactor ecc_sign_hash_ex
d286de1
@karel-m
refactor ecc_verify_hash_ex
9d74895
@sjaeckel @karel-m
allow compilation of ECC w/o DER
d96dd76 
via e.g.

```
make -j9 EXTRALIBS="../libtommath/libtommath.a " \
	CFLAGS="-DLTC_NOTHING -DLTC_MINIMAL -DLTC_MECC -DUSE_LTM \
	-DLTM_DESC -I../libtommath"
```
@sjaeckel @karel-m
update SSH API
230b1fc
@sjaeckel @karel-m
argument checks before allocation
6be0836
@sjaeckel @karel-m
add some sanity checks
63fd926
@karel-m
Update makefiles
d708fe7
@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch from d1ac928 to d708fe7 Compare April 11, 2021 14:39
@sjaeckel sjaeckel mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaeckel sjaeckel sjaeckel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@karel-m @sjaeckel