An attempt to fix #449 (ECDSA forcing DER/ASN.1) #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
ee8b8b5 to
7fda795
Compare
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
7fda795 to
41d9ee3
Compare
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
41d9ee3 to
8e2b645
Compare
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
8e2b645 to
5613bae
Compare
|
so we wait now until the two missing points are done? |
|
If you agree with the proposed split, which I assume you do, I (or any other volunteer) have to update doc and tests. |
|
👍 |
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
2 times, most recently
from
797f10c to
9340721
Compare
sjaeckel
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
9340721 to
d1ac928
Compare
karel-m
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
d1ac928 to
d708fe7
Compare
sjaeckel
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
f4d044e to
a616dbb
Compare
levitte
reviewed
Jan 9, 2025
via e.g. ``` make -j9 EXTRALIBS="../libtommath/libtommath.a " \ CFLAGS="-DLTC_NOTHING -DLTC_MINIMAL -DLTC_MECC -DUSE_LTM \ -DLTM_DESC -I../libtommath" ```
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
pr/ecdsa-der-attempt1
branch
from
a616dbb to
46bf532
Compare
Sure! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is incomplete (as I am not sure if it is the proper fix).
Cc: @sjaeckel @rmw42
TODO:
EDIT: Hopefully fixes #449 -- /RL