WIP: Native res stuff #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmrlawson
force-pushed
the
rebase_native_res
branch
from
92a2e95 to
989ede1
Compare
…/height to 640x480
dmrlawson
force-pushed
the
rebase_native_res
branch
from
989ede1 to
4c29e5a
Compare
|
As I understand, the overscan related issue is being discussed here: gonetz/GLideN64#2301 If I understand correctly, it sounds like what I was coming to suspect, that with Overscan (i.e. cropping/removal of overscan) the rendered image is projected onto an additional frame buffer (which emulates the VI). This PR uses the resolution of the VI as the window resolution passed to Retroarch. With Overscan disabled this additional frame buffer isn't used so we get the wrong resolution passed to retroarch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a pull request to track progress of this. Not intended to be merged at the moment.
This branch is intended to add the stuff @m4xw wrote in the
native_resbranch but rebased on top ofdevelop.I copied in the @m4xw's stuff because the real rebase looked frightening.
It currently seems to work so long as
Overscan = Enabled/True. Otherwise the image is stretched and off centre.I'm looking into why this is at the moment.