Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth open URL in default browser, set success message and throw desc… #1396

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

OAuth open URL in default browser, set success message and throw desc… #1396

wants to merge 1 commit into from
+187 −18

Conversation

stevenleadbeater
Copy link

  • [oauth] Open authorization URL in default browser
  • [oauth] Allow optionally passing success message to display on browser return page
  • [oauth] Throw specific errors on failure states

@kingosticks
Copy link
Contributor

My initial thought is I should have made this an object rather than just a function, having to break the API just to support a custom response message is a shame.

@stevenleadbeater
Copy link
Author

My initial thought is I should have made this an object rather than just a function, having to break the API just to support a custom response message is a shame.

Is it worth working this up a bit more so that there are overloads instead without too much copy paste? I don't mind doing the leg work on that. It would mean you can keep the existing API and we can add a method to pass the message

@kingosticks
Copy link
Contributor

I think that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingosticks kingosticks Awaiting requested review from kingosticks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenleadbeater @kingosticks