fix: check if streams is initialized #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Nov 20, 2024
| @@ -141,11 +141,11 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions { | |||
| private lateinit var streams: Streams | |||
| val isShort | |||
| get() = run { | |||
| val heightGreaterThanWidth = streams.videoStreams.firstOrNull()?.let { | |||
| val heightGreaterThanWidth = ::streams.isInitialized && streams.videoStreams.first().let { | |||
There was a problem hiding this comment.
videoStreams can in fact be empty for some live streams, hence changing it to first() would cause yet another crash.
Fixes a crash when trying to rotate the player before it is initialized.
FineFindus
force-pushed
the
fix/rotate-crash
branch
from
566293e
to
75d6e73
Compare
Bnyro
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when trying to rotate the player before it is initialized, most likely introduced in 76d7c62.