feat(channelGroups): allow re-ordering of groups #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not yet self-explaining to users that it's possible to reorder them - I think we should add an indicator for that like it's present in the queue bottom sheet or in the navigation bar order options dialog. |
FineFindus
force-pushed
the
feat/reorder-channel-groups
branch
from
581c7c9
to
2b5a1d0
Compare
|
|
|
Those icons could also be used. |
I get that, but there's no other way to tell users that they can re-order these. The drag handle should be at the left though, so that it can be clearly distinguished from the edit and delete icon. |
Isira-Seneviratne
approved these changes
Aug 20, 2023
app/src/main/java/com/github/libretube/ui/sheets/ChannelGroupsSheet.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/libretube/ui/fragments/SubscriptionsFragment.kt
Outdated
Show resolved
Hide resolved
Bnyro
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3558 by allowing channel groups to be rearranged using DnD.
libretube_reorder_channel_groups.mp4
This will currently update all groups in the database, this may cause problems with larger sets of groups, in which case it may be worth checking which groups need updating.
Due to the other issues listed in #3558 with the Ui, I did not add drag handles.