chore: remove WindowUpdateMode::OnReceive
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Nov 23, 2023
yamux/src/connection.rs
Outdated
| } | ||
| // The remote has either still credit or will be given more | ||
| // (due to an enqueued window update or because the update | ||
| // mode is `OnReceive`) or we already have inbound frames in |
|
Moving forward here. In case we want to cut a patch release of the |
Comment on lines
+505
to
+511
| // The remote has either still credit or will be given more | ||
| // due to an enqueued window update or we already have | ||
| // inbound frames in the socket buffer which will be | ||
| // processed later. In any case we will reply with an RST in | ||
| // `Connection::on_data` because the stream will no longer | ||
| // be known. | ||
| None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to previous deprecation #177.
Fixes #175.