Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require external confirmation of public addresses #2867

Merged
merged 5 commits into from
Dec 4, 2024
Merged

fix: require external confirmation of public addresses #2867

merged 5 commits into from
Dec 4, 2024

Conversation

achingbrain
Copy link
Member

Requires autonat to confirm external IP addresses and domain names before the node will announce them.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: require external confirmation of public addresses
8165024 
Requires autonat to confirm external IP addresses and domain names
before the node will announce them.
@achingbrain achingbrain requested a review from a team as a code owner November 30, 2024 13:41
maschad
maschad reviewed Dec 1, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left some suggestions

packages/interface-internal/src/address-manager/index.ts Show resolved Hide resolved
packages/interface-internal/src/address-manager/index.ts Outdated Show resolved Hide resolved
packages/libp2p/src/address-manager.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit d19974d into main Dec 4, 2024
31 of 32 checks passed
@achingbrain achingbrain deleted the fix/require-address-confirmation branch December 4, 2024 15:51
@achingbrain achingbrain mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad