Skip to content

Commit

Permalink
chore: deprecate old peer-store api
Browse files Browse the repository at this point in the history 
BREAKING CHANGE: the peer-store api changed. Check the API docs for the new specification.
  • Loading branch information
@vasco-santos
vasco-santos committed Apr 1, 2020
1 parent eb27b8d commit 98004ad
Show file tree
Hide file tree
Showing 6 changed files with 71 additions and 139 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"libp2p-delegated-peer-routing": "^0.4.0",
"libp2p-floodsub": "^0.20.0",
"libp2p-gossipsub": "^0.2.0",
"libp2p-kad-dht": "^0.18.2",
"libp2p-kad-dht": "libp2p/js-libp2p-kad-dht#chore/use-new-peer-store-api",
"libp2p-mdns": "^0.13.0",
"libp2p-mplex": "^0.9.1",
"libp2p-secio": "^0.12.1",
Expand Down
10 changes: 9 additions & 1 deletion src/peer-store/address-book.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class AddressBook extends Book {

/**
* @constructor
* @param {EventEmitter} peerStore
* @param {PeerStore} peerStore
*/
constructor (peerStore) {
super(peerStore, 'change:multiaddrs', 'multiaddrs')
Expand Down Expand Up @@ -120,6 +120,7 @@ class AddressBook extends Book {
}

this.data.set(id, multiaddrInfos)
this._setPeerId(peerId)
log(`stored provided multiaddrs for ${id}`)

// TODO: Remove peerInfo and its usage on peer-info deprecate
Expand Down Expand Up @@ -166,6 +167,7 @@ class AddressBook extends Book {
return [...multiaddrInfos]
}

this._setPeerId(peerId)
this.data.set(id, multiaddrInfos)

log(`added provided multiaddrs for ${id}`)
Expand All @@ -189,6 +191,12 @@ class AddressBook extends Book {
return [...multiaddrInfos]
}

_setPeerId (peerId) {
if (!this._ps.peerIds.get(peerId)) {
this._ps.peerIds.set(peerId.toString(), peerId)
}
}

/**
* Get the known multiaddrs for a given peer. All returned multiaddrs
* will include the encapsulated `PeerId` of the peer.
Expand Down
98 changes: 8 additions & 90 deletions src/peer-store/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,97 +43,13 @@ class PeerStore extends EventEmitter {
* ProtoBook containing a map of peerIdStr to supported protocols.
*/
this.protoBook = new ProtoBook(this)
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Stores the peerInfo of a new peer on each book.
* @param {PeerInfo} peerInfo
* @param {object} [options]
* @param {boolean} [options.replace = true]
* @return {PeerInfo}
*/
put (peerInfo, options) {
const multiaddrs = peerInfo.multiaddrs.toArray()
const protocols = Array.from(peerInfo.protocols || new Set())

this.addressBook.set(peerInfo.id, multiaddrs, options)
this.protoBook.set(peerInfo.id, protocols, options)

const peer = this.find(peerInfo.id)
const pInfo = new PeerInfo(peerInfo.id)

if (!peer) {
return pInfo
}

peer.protocols.forEach((p) => pInfo.protocols.add(p))
peer.multiaddrInfos.forEach((mi) => pInfo.multiaddrs.add(mi.multiaddr))

return pInfo
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Get the info of the given id.
* @param {peerId} peerId
* @returns {PeerInfo}
*/
get (peerId) {
const peer = this.find(peerId)

const pInfo = new PeerInfo(peerId)
peer.protocols.forEach((p) => pInfo.protocols.add(p))
peer.multiaddrInfos.forEach((mi) => pInfo.multiaddrs.add(mi.multiaddr))

return pInfo
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Has the info to the given id.
* @param {PeerId} peerId
* @returns {boolean}
*/
has (peerId) {
return Boolean(this.find(peerId))
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Removes the peer provided.
* @param {PeerId} peerId
* @returns {boolean} true if found and removed
*/
remove (peerId) {
return this.delete(peerId)
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Completely replaces the existing peers metadata with the given `peerInfo`
* @param {PeerInfo} peerInfo
* @returns {void}
*/
replace (peerInfo) {
this.put(peerInfo)
}

// TODO: Temporary adapter for modules using PeerStore
// This should be removed under a breaking change
/**
* Returns the known multiaddrs for a given `PeerInfo`. All returned multiaddrs
* will include the encapsulated `PeerId` of the peer.
* @param {PeerInfo} peerInfo
* @returns {Array<Multiaddr>}
*/
multiaddrsForPeer (peerInfo) {
return this.addressBook.getMultiaddrsForPeer(peerInfo.id)
/**
* TODO: this should only exist until we have the key-book
* Map known peers to their peer-id.
* @type {Map<string, Array<PeerId>}
*/
this.peerIds = new Map()
}

/**
Expand Down Expand Up @@ -204,6 +120,7 @@ class PeerStore extends EventEmitter {
throw errcode(new Error('peerId must be an instance of peer-id'), ERR_INVALID_PARAMETERS)
}

const id = this.peerIds.get(peerId.toString())
const multiaddrInfos = this.addressBook.get(peerId)
const protocols = this.protoBook.get(peerId)

Expand All @@ -212,6 +129,7 @@ class PeerStore extends EventEmitter {
}

return {
id: id || peerId,
multiaddrInfos: multiaddrInfos || [],
protocols: protocols || []
}
Expand Down
10 changes: 9 additions & 1 deletion src/peer-store/proto-book.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const {
class ProtoBook extends Book {
/**
* @constructor
* @param {EventEmitter} peerStore
* @param {PeerStore} peerStore
*/
constructor (peerStore) {
super(peerStore, 'change:protocols', 'protocols')
Expand Down Expand Up @@ -94,6 +94,7 @@ class ProtoBook extends Book {
}

this.data.set(id, newSet)
this._setPeerId(peerId)
log(`stored provided protocols for ${id}`)

// TODO: Remove peerInfo and its usage on peer-info deprecate
Expand Down Expand Up @@ -130,6 +131,7 @@ class ProtoBook extends Book {
protocols = [...newSet]

this.data.set(id, newSet)
this._setPeerId(peerId)
log(`added provided protocols for ${id}`)

// TODO: Remove peerInfo and its usage on peer-info deprecate
Expand All @@ -145,6 +147,12 @@ class ProtoBook extends Book {
return protocols
}

_setPeerId (peerId) {
if (!this._ps.peerIds.get(peerId)) {
this._ps.peerIds.set(peerId.toString(), peerId)
}
}

/**
* Verify if the provided peer supports the given protocols.
* @param {PeerId} peerId
Expand Down
45 changes: 22 additions & 23 deletions test/peer-store/address-book.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ chai.use(require('dirty-chai'))
const { expect } = chai
const sinon = require('sinon')

const { EventEmitter } = require('events')
const pDefer = require('p-defer')
const multiaddr = require('multiaddr')

const AddressBook = require('../../src/peer-store/address-book')
const PeerStore = require('../../src/peer-store')

const peerUtils = require('../utils/creators/peer')
const {
Expand All @@ -31,15 +30,15 @@ describe('addressBook', () => {
})

describe('addressBook.set', () => {
let ee, ab
let peerStore, ab

beforeEach(() => {
ee = new EventEmitter()
ab = new AddressBook(ee)
peerStore = new PeerStore()
ab = peerStore.addressBook
})

afterEach(() => {
ee.removeAllListeners()
peerStore.removeAllListeners()
})

it('throwns invalid parameters error if invalid PeerId is provided', () => {
Expand Down Expand Up @@ -67,7 +66,7 @@ describe('addressBook', () => {

const supportedMultiaddrs = [addr1, addr2]

ee.once('change:multiaddrs', ({ peerId, multiaddrs }) => {
peerStore.once('change:multiaddrs', ({ peerId, multiaddrs }) => {
expect(peerId).to.exist()
expect(multiaddrs).to.eql(supportedMultiaddrs)
defer.resolve()
Expand All @@ -93,7 +92,7 @@ describe('addressBook', () => {
const finalMultiaddrs = supportedMultiaddrsA.concat(supportedMultiaddrsB)

let changeTrigger = 2
ee.on('change:multiaddrs', ({ multiaddrs }) => {
peerStore.on('change:multiaddrs', ({ multiaddrs }) => {
changeTrigger--
if (changeTrigger === 0 && arraysAreEqual(multiaddrs, finalMultiaddrs)) {
defer.resolve()
Expand Down Expand Up @@ -124,7 +123,7 @@ describe('addressBook', () => {
const supportedMultiaddrsB = [addr2]

let changeCounter = 0
ee.on('change:multiaddrs', () => {
peerStore.on('change:multiaddrs', () => {
changeCounter++
if (changeCounter > 1) {
defer.resolve()
Expand All @@ -148,7 +147,7 @@ describe('addressBook', () => {
const supportedMultiaddrs = [addr1, addr2]

let changeCounter = 0
ee.on('change:multiaddrs', () => {
peerStore.on('change:multiaddrs', () => {
changeCounter++
if (changeCounter > 1) {
defer.reject()
Expand Down Expand Up @@ -177,7 +176,7 @@ describe('addressBook', () => {
const finalMultiaddrs = supportedMultiaddrsA.concat(supportedMultiaddrsB)

let changeCounter = 0
ee.on('change:multiaddrs', () => {
peerStore.on('change:multiaddrs', () => {
changeCounter++
if (changeCounter > 1) {
defer.resolve()
Expand All @@ -202,7 +201,7 @@ describe('addressBook', () => {
const supportedMultiaddrsB = [addr2]

let changeCounter = 0
ee.on('change:multiaddrs', () => {
peerStore.on('change:multiaddrs', () => {
changeCounter++
if (changeCounter > 1) {
defer.reject()
Expand All @@ -225,11 +224,11 @@ describe('addressBook', () => {
})

describe('addressBook.get', () => {
let ee, ab
let peerStore, ab

beforeEach(() => {
ee = new EventEmitter()
ab = new AddressBook(ee)
peerStore = new PeerStore()
ab = peerStore.addressBook
})

it('throwns invalid parameters error if invalid PeerId is provided', () => {
Expand All @@ -256,11 +255,11 @@ describe('addressBook', () => {
})

describe('addressBook.getMultiaddrsForPeer', () => {
let ee, ab
let peerStore, ab

beforeEach(() => {
ee = new EventEmitter()
ab = new AddressBook(ee)
peerStore = new PeerStore()
ab = peerStore.addressBook
})

it('throwns invalid parameters error if invalid PeerId is provided', () => {
Expand Down Expand Up @@ -288,11 +287,11 @@ describe('addressBook', () => {
})

describe('addressBook.delete', () => {
let ee, ab
let peerStore, ab

beforeEach(() => {
ee = new EventEmitter()
ab = new AddressBook(ee)
peerStore = new PeerStore()
ab = peerStore.addressBook
})

it('throwns invalid parameters error if invalid PeerId is provided', () => {
Expand All @@ -304,7 +303,7 @@ describe('addressBook', () => {
it('returns false if no records exist for the peer and no event is emitted', () => {
const defer = pDefer()

ee.on('change:multiaddrs', () => {
peerStore.on('change:multiaddrs', () => {
defer.reject()
})

Expand All @@ -327,7 +326,7 @@ describe('addressBook', () => {
ab.set(peerId, supportedMultiaddrs)

// Listen after set
ee.on('change:multiaddrs', ({ multiaddrs }) => {
peerStore.on('change:multiaddrs', ({ multiaddrs }) => {
expect(multiaddrs.length).to.eql(0)
defer.resolve()
})
Expand Down
Loading

0 comments on commit 98004ad

Please sign in to comment.