fix: return error if dialing ma without id

libp2p · Jun 22, 2018 · 2a5832c · 2a5832c
1 parent 4238cb8
commit 2a5832c
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -45,9 +45,13 @@ class WebRTCStar {
 
     callback = callback ? once(callback) : noop
 
-    let b58 = ma.split('ipfs/').pop()
+    let peerId = ma.getPeerId()
 
-    log('dialing %s (id=%s)', ma, b58)
+    log('dialing %s (id=%s)', ma, peerId)
+
+    if (!peerId) {
+      return callback(new Error('Cannot dial peer: No Id provided!'))
+    }
 
     const spOptions = { initiator: true, trickle: false }
 
@@ -61,7 +65,7 @@ class WebRTCStar {
 
     channel.on('signal', (signal) => {
       log('dial#%s got signal', ma)
-      this.exchange.request(Id.createFromB58String(b58), 'webrtc', Buffer.from(JSON.stringify({signal})), (err, result) => {
+      this.exchange.request(Id.createFromB58String(peerId), 'webrtc', Buffer.from(JSON.stringify({signal})), (err, result) => {
         if (err) {
           log('dial#%s exchange failed %s', ma, err)
           return callback(err)