chore: update kbucket #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Apr 6, 2020
| @@ -222,10 +222,10 @@ func (dht *IpfsDHT) refreshCpls(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := doQuery(tcpl.Cpl, randPeer.String(), walkFnc); err != nil { | |||
| if err := doQuery(uint(cpl), randPeer.String(), walkFnc); err != nil { | |||
There was a problem hiding this comment.
TODO: #550 (in a diferent PR)
|
Some options:
My recommendation here is to do 1a, it's easy and keeps the test true to how it was behaving before this PR. |
…nd refresh routing tables for orphaned nodes
aschmahmann
reviewed
Apr 6, 2020
Comment on lines
+1417
to
+1420
| if len(d.RoutingTable().ListPeers()) > 0 { | ||
| if err := <-d.RefreshRoutingTable(); err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
This test had to be modified because of #549 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.