Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more attributes to traces #1002

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

2color
Copy link
Contributor

@2color 2color commented Nov 22, 2024

The following should help us to inspect more closely when additional peer routing requests are necessary when looking for providers.

The context for this is someguy, whereby we observe that many providers are returned with no multiaddrs.

Related: ipfs/someguy#16

@2color 2color requested review from guillaumemichel and a team as code owners November 22, 2024 12:37
Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @2color

@guillaumemichel guillaumemichel merged commit 352305e into master Nov 22, 2024
8 of 9 checks passed
@guillaumemichel guillaumemichel deleted the improve-tracing branch November 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants