Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of external intrinsics with processing & replacment header content #235

Open
wants to merge 10 commits into
base: devel
Choose a base branch
from
Open

implementation of external intrinsics with processing & replacment header content #235

wants to merge 10 commits into from

Conversation

vyast-softserveinc
Copy link
Collaborator

No description provided.

kchabSS
kchabSS reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@kchabSS kchabSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Just a few small places to address.

lib/util/string_utils.hpp Outdated Show resolved Hide resolved
lib/core/intrinsics/external_intrinsics.cpp Outdated Show resolved Hide resolved
lib/core/intrinsics/external_intrinsics.h Outdated Show resolved Hide resolved
lib/core/transpiler_session/code_generator.cpp Outdated Show resolved Hide resolved
lib/core/utils/for_stmt_parser.cpp Outdated Show resolved Hide resolved
lib/core/vfs/overlay_fs.cpp Outdated Show resolved Hide resolved
lib/pipeline/core/stage_action_runner.cpp Show resolved Hide resolved
lib/util/string_utils.cpp Outdated Show resolved Hide resolved
IuriiKobein
IuriiKobein approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@IuriiKobein IuriiKobein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. The test on OCCA intrinsic examples will show if it works.

lib/core/transpiler_session/header_info.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchabSS kchabSS kchabSS left review comments

@IuriiKobein IuriiKobein IuriiKobein approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyast-softserveinc @IuriiKobein @kchabSS