Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permutation decoding #36

Merged
merged 14 commits into from
Oct 28, 2024
Merged

Permutation decoding #36

merged 14 commits into from
Oct 28, 2024

Conversation

mo271
Copy link
Member

@mo271 mo271 commented Oct 25, 2024

on top of #35

tirr-c
tirr-c reviewed Oct 27, 2024
View reviewed changes
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
tirr-c
tirr-c approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I need that Lehmer code decoding for jxl-oxide 😝

Some Rust-specific nitpicks:

jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
jxl/src/headers/permutation.rs Outdated Show resolved Hide resolved
@mo271
Copy link
Member Author

mo271 commented Oct 28, 2024

Maybe I need that Lehmer code decoding for jxl-oxide 😝

Sounds like a good idea to me!

Some Rust-specific nitpicks:

Thanks for all of those, they are very helpful for me!

@mo271 mo271 requested a review from veluca93 October 28, 2024 13:06
@mo271 mo271 merged commit 6bceb0b into libjxl:main Oct 28, 2024
3 checks passed
@mo271 mo271 mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirr-c tirr-c tirr-c approved these changes

@veluca93 veluca93 veluca93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mo271 @veluca93 @tirr-c