-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make prepared geometry (more?) thread-safe #826
Open
dbaston
wants to merge
8
commits into
libgeos:main
Choose a base branch
from
dbaston:prep-geom-threadsafe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
force-pushed
the
prep-geom-threadsafe
branch
from
February 16, 2023 02:55
09bdab4
to
996f7e2
Compare
This is subject to a data race if built() is called while the tree is being constructed.
dbaston
force-pushed
the
prep-geom-threadsafe
branch
from
March 1, 2023 00:57
996f7e2
to
f89069e
Compare
@dbaston This says it's slated for 3.13, is that still true, or should we push to 3.14. I've pushed to 3.14, push back if I am mistaken. |
This was referenced Sep 4, 2024
Hi, I believe we are seeing this in roaring-landmask (gauteh/roaring-landmask#25) through the rust-bindings (georust/geos#95). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes prepared geometries thread-safe, or at least more thread safe than they used to be. The clang thread sanitizer reports no errors on the included test.
valgrind --tool=helgrind
reports many, but I'm wondering it isn't correctly understanding thestd::call_once
construct.This introduces a few number of inconsistencies with JTS. I think they are pretty minor.
MonotoneChain::getEnvelope
no longer takes anexpansionDistance
argument. That distance is now provided toMonotoneChainBuilder
, and the envelopes are eagerly constructed. The previous handling of this parameter was arguably incorrect, in any case.MCIndexSegmentSetMutualIntersector::process
can now accept aSegmentIntersector
argument so that multiple threads can callprocess
with their ownSegmentIntersector
. I did not change the entireSegmentSetMutualIntersector
interface, just this one class.FastSegmentSetIntersector
no longer shares aLineIntersector
between calls.IndexedPointInAreaLocator
eagerly builds its index. This should be OK since the locator itself is (usually?) lazily-constructed.I haven't yet done performance testing to see if there is a penalty for single-threaded uses.