Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add workflow to build Python wheels #66

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

@glensc
Copy link
Contributor Author

glensc commented Feb 17, 2024

@sdelafond are you going to squash merge again this, or I will try to make reasonable commits?

@sdelafond
Copy link
Collaborator

@sdelafond are you going to squash merge again this, or I will try to make reasonable commits?

At this point I'll most likely end up squashing it, but in general it'd be good to open the PR only after you get everything sort of working in your fork :)

@glensc
Copy link
Contributor Author

glensc commented Feb 17, 2024

maybe makes sense to always build the artifacts? i.e. to see that the changes in PR didn't break anything and release build would succeed. could omit uploading the artifacts.

@glensc
Copy link
Contributor Author

glensc commented Feb 17, 2024

Also, do you need merged artifacts?

@glensc
Copy link
Contributor Author

glensc commented Feb 17, 2024

It should be feature-ready from my side.

@sdelafond
Copy link
Collaborator

I'll let the dust settle a bit, and will review it later on: right now it keeps changing on me every other second which makes it harder than it should be :)

@glensc glensc marked this pull request as ready for review February 17, 2024 15:14
@glensc
Copy link
Contributor Author

glensc commented Feb 17, 2024

Since you said you'll consider not-squashing, cleaned up the commits :)

Copy link
Collaborator

@sdelafond sdelafond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks all good.

.github/workflows/wheels.yml Outdated Show resolved Hide resolved
@sdelafond sdelafond merged commit 1cdf87b into libfuse:master Feb 27, 2024
8 checks passed
@sdelafond
Copy link
Collaborator

Thanks a lot for your contribution!

@glensc glensc deleted the wheels branch February 28, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants