-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add workflow to build Python wheels #66
Conversation
@sdelafond are you going to squash merge again this, or I will try to make reasonable commits? |
At this point I'll most likely end up squashing it, but in general it'd be good to open the PR only after you get everything sort of working in your fork :) |
maybe makes sense to always build the artifacts? i.e. to see that the changes in PR didn't break anything and release build would succeed. could omit uploading the artifacts. |
Also, do you need merged artifacts? |
It should be feature-ready from my side. |
I'll let the dust settle a bit, and will review it later on: right now it keeps changing on me every other second which makes it harder than it should be :) |
Since you said you'll consider not-squashing, cleaned up the commits :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks all good.
Thanks a lot for your contribution! |
Fixes:
Refs: